Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notmuch: 0.28.1 -> 0.28.2 #55974

Merged
merged 1 commit into from Feb 19, 2019
Merged

notmuch: 0.28.1 -> 0.28.2 #55974

merged 1 commit into from Feb 19, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 18, 2019

https://notmuchmail.org/pipermail/notmuch/2019/027402.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Feb 18, 2019

@GrahamcOfBorg build notmuch

Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test failure on darwin. Did that test fail before?

@flokli
Copy link
Contributor

flokli commented Feb 19, 2019

@pSub that's a xapian test already, see #55952.

@pSub
Copy link
Member

pSub commented Feb 19, 2019

Oh, I see. Then this looks good to me.

@pSub pSub merged commit 5678098 into NixOS:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants