New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildRustCrate support editions #55972
Conversation
Previously build flags would not be available during the configure phase while they might be required to build the `build.rs` file.
In combination with carnix we can now build crates that require a specific edition of rust features. A few crates started requiring that already and having this in nixpkgs is just logical.
@GrahamcOfBorg build carnix buildRustCrateTests toml2nix cargo-download cargo-vendor cargo-update |
I published the patch in pijul in the meantime: https://nest.pijul.com/pmeunier/carnix/discussions/27 |
@GrahamcOfBorg build carnix buildRustCrateTests toml2nix cargo-download cargo-vendor cargo-update |
The Nix changes look good to me, haven't looked at the The upstream carnix repo hasn't seen any changes in a while. After I made my Github mirror of it, it was forked to nix-community. Should we maybe update that repository and submit patches such as the edition one there? |
@tazjin: the README in your fork states that the webpage GitHub, just like nest.pijul.com, allows people to delete repositories, and you can get a 404 from GitHub and from the Pijul Nest if the authors move their repositories, which is what happened here. Also, I just accepted the edition patch, about a week after it's been submitted to that repository, which is not at all an unreasonable delay. Obviously, the license of Carnix doesn't prevent you from forking it and maintaining a fork on GitHub, but I wrote about 95% of this tool, and while I agree that writing and maintaining an almost accurate README is a useful contribution, these few lines of text are still your main contribution to this project so far. Not only have you not cared to submit that contribution to the original repository, but you're also falsely implying in that README that this project has been abandoned, and that your GitHub repository is the new project home. You could at least have asked me directly before doing this. |
@P-E-Meunier It hasn't been easy to get a hold of you on IRC, the Nest, Github or elsewhere - and not for a lack of trying. What is your preferred method of communication? The second sentence of the README points people at the current repository on Pijul and has done so for a while. The README also makes it abundantly clear that the fork is not the development repository of carnix, and is merely attempting to track the source for the various versions of carnix on crates.io. As I've just pushed the sources of Carnix 0.8.6 - 0.9.6 (extracted from crates.io, as it is not easily possible to get those from the patch list) I can take care of updating the README and making this even clearer. Occasionally people will go looking for the source of
I'm not claiming to be a contributor to I am grateful for your work on
This isn't really relevant to this discussion, but Github establishes redirects if repositories are moved. (See for example the redirect on google/pulldown-cmark). This may be a useful feature to add to the Nest. |
Motivation for this change
This is my initial version of editions support. I have a local change to
carnix
that also exposed the edition field (if availabe). I can finally build my private projects again that have dependencies with anedition = 2018
field in theCargo.toml
. \o/Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)I am currently unable to apply / upload / propose the changes to carnix since my account is never created (tried months ago, tried now, …). One of the patches I wrote is below (the one for this PR; the other one crashes pijul :/). (cc @P-E-Meunier)