Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 0.99.0 -> 0.99.1.1 #55889

Merged
merged 1 commit into from Feb 17, 2019
Merged

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Feb 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Feb 16, 2019

@GrahamcOfBorg build matrix-synapse

@Ekleog
Copy link
Member

Ekleog commented Feb 16, 2019

@GrahamcOfBorg build nixosTests.matrix-synapse

@delroth
Copy link
Contributor

delroth commented Feb 16, 2019

LGTM, running fine on my setup.

@Ekleog
Copy link
Member

Ekleog commented Feb 17, 2019

All tests passed, let's merge. Thanks @pacien !

cc @Ralith @roblabla

Just as an aside, it can be considered polite to cc the package's maintainers when doing a PR that touches it, so they are aware someone else is working on it (at least until something like NixOS/rfcs#39 gets merged).

And as a second aside, maybe you want to add yourself to the maintainer list, @pacien? You appear to care about synapse enough for it… can't remember whether I already asked you, though :)

@Ekleog Ekleog merged commit 688f734 into NixOS:master Feb 17, 2019
@pacien
Copy link
Contributor Author

pacien commented Feb 17, 2019

Just as an aside, it can be considered polite to cc the package's maintainers when doing a PR that touches it, so they are aware someone else is working on it (at least until something like NixOS/rfcs#39 gets merged).

I noticed that ofborg requests reviews from maintainers automatically.
Though… it only poked you and not the other ones?

And as a second aside, maybe you want to add yourself to the maintainer list, @pacien? You appear to care about synapse enough for it… can't remember whether I already asked you, though :)

Indeed, I'll add myself on the next update.

@Ekleog
Copy link
Member

Ekleog commented Feb 17, 2019

It only poked me because NixOS/rfcs#39 hasn't been merged and implemented yet, and it can technically poke only members of the NixOS organization currently :) Unfortunately, for the time being we need to manually poke maintainers most of the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants