Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ats2: 0.3.12 -> 0.3.13 #55899

Merged
merged 1 commit into from Feb 16, 2019
Merged

ats2: 0.3.12 -> 0.3.13 #55899

merged 1 commit into from Feb 16, 2019

Conversation

bbarker
Copy link
Contributor

@bbarker bbarker commented Feb 16, 2019

Motivation for this change
  • Updating to latest version; now supports building ATS3 using the nix expression in the ATS3 repo!
  • Due to upcoming packaging changes with ATS2, the -gmp release will be the
    same as the old release, and it is the most full-featured release. So
    nothing is changing other than the .tgz archive name.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip --against master^"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Due to upcoming packaging changes with ATS2, the -gmp release will be the
same as the old release, and it is the most full-featured release. So
nothing is changing other than the .tgz archive name.
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ttuegel ttuegel merged commit 87f3bce into NixOS:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants