Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo: 0.50 -> 0.54.0 #55915

Merged
merged 1 commit into from Feb 22, 2019
Merged

hugo: 0.50 -> 0.54.0 #55915

merged 1 commit into from Feb 22, 2019

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Feb 16, 2019

Motivation for this change

Upgrade Hugo from 0.50 to 0.54.0.

I had to do some manual adding of packages to the deps.nix file to get it to build, so I'm not really sure if the versions I've included for gobuffalo/envy or joho/godotenv are exactly correct, but it built and ran fine on my computer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sondr3 sondr3 marked this pull request as ready for review February 16, 2019 21:08
@sondr3
Copy link
Contributor Author

sondr3 commented Feb 16, 2019

I've confirmed that this can successfully build the documentation repo for Hugo itself, so I'm assuming that it works. cc @schneefux for some input 😃

@etu
Copy link
Contributor

etu commented Feb 17, 2019

@GrahamcOfBorg build hugo

@sondr3
Copy link
Contributor Author

sondr3 commented Feb 17, 2019

I'll look into the macOS failure tomorrow.

@etu
Copy link
Contributor

etu commented Feb 17, 2019

goPackagePath = "github.com/gobuffalo/envy";
fetch = {
type = "git";
url = "https://github.com/gobuffalo/envy";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not found any references to this in the go code itself.
Do you know where this is used?

Copy link
Member

@Mic92 Mic92 Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it is a test dependency only, the following will help:

subPackages = [ "." ];

this will make it build only the main package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I’ll look into it tomorrow. It wouldn’t build without them though.

@sondr3
Copy link
Contributor Author

sondr3 commented Feb 18, 2019

I just built the package on my macOS machine and it built and worked, though it wouldn't work with the two manually added packages removed and subPackages = [ "." ]; added to default.nix. According to the issue I opened:

What I think is going on here has to do with the upstream use of the replace directive in go.mod: https://github.com/gohugoio/hugo/blob/v0.54.0/go.mod#L64.
inflect removed their dependency on envy, but replace pulls in a version of inflect that still depends on envy.

Not really sure what to make of the build errors on aarch64 and darwin.

@Mic92
Copy link
Member

Mic92 commented Feb 22, 2019

You can ignore the error on aarch64 as this is just a resource depletion on the builder. On macOS it seems like it did not had git available at the time.

@Mic92
Copy link
Member

Mic92 commented Feb 22, 2019

@sondr3 so you are saying this is a bug in vgo2nix then? We can merge this as it is, but this should be also reported here: https://github.com/adisbladis/vgo2nix

@sondr3
Copy link
Contributor Author

sondr3 commented Feb 22, 2019

I've asked about it being a bug in vgo2nix and will await his reply, it's probably due to the way the replace directive works. Regarding macOS, I had to manually compile and test git there, so it took forever on my machine to actually build it so it's probably similar on the macOS tester. But yeah, it should be fine to merge as-is, it works on both my machine.

@Mic92 Mic92 merged commit 8f0cba1 into NixOS:master Feb 22, 2019
@sondr3 sondr3 deleted the sondr3/update-hugo-0.54 branch February 25, 2019 19:15
@commandodev
Copy link
Contributor

This doesn't seem to be working for me:

github.com/gohugoio/hugo/tpl/tplimpl/embedded
github.com/gohugoio/hugo/tpl/tplimpl/embedded/generate
github.com/gohugoio/hugo/parser/metadecoders
# github.com/gohugoio/hugo/parser/metadecoders
go/src/github.com/gohugoio/hugo/parser/metadecoders/decoder.go:45:9: undefined: strings.Builder
github.com/gohugoio/hugo/parser/metadecoders
# github.com/gohugoio/hugo/parser/metadecoders
go/src/github.com/gohugoio/hugo/parser/metadecoders/decoder.go:45:9: undefined: strings.Builder
github.com/gohugoio/hugo/transform
github.com/gohugoio/hugo/parser/metadecoders
# github.com/gohugoio/hugo/parser/metadecoders
go/src/github.com/gohugoio/hugo/parser/metadecoders/decoder.go:45:9: undefined: strings.Builder
github.com/gohugoio/hugo/parser/metadecoders
# github.com/gohugoio/hugo/parser/metadecoders
go/src/github.com/gohugoio/hugo/parser/metadecoders/decoder.go:45:9: undefined: strings.Builder
github.com/gohugoio/hugo/transform/urlreplacers
github.com/gohugoio/hugo/watcher
builder for '/nix/store/vi4z60d2bmvxnndnsm0lz9yqr7wz550i-hugo-0.54.0.drv' failed with exit code 62
cannot build derivation '/nix/store/mrjkq8dambn9qavjd96621crc8q97sm7-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gx96jidq831scniqnbdqk5xh43sc26dq-nixos-system-xps15-18.03.133389.b551f89e256.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gx96jidq831scniqnbdqk5xh43sc26dq-nixos-system-xps15-18.03.133389.b551f89e256.drv' failed

@sondr3
Copy link
Contributor Author

sondr3 commented Mar 14, 2019

How are you installing the package? I just tried again on both my machines and a Docker image and it worked on all of them. The error also stems from one of the source files, which is strange as it means that there's something missing in the source code and not directly a build issue. In any case, this'll probably get resolved by #57080.

@commandodev
Copy link
Contributor

@sondr3 it looks like this stems from me trying to overlay just this package from nixpkgs on top of the channel that my system's pointed at. I'm going to mark it down as user error :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants