-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo: 0.50 -> 0.54.0 #55915
hugo: 0.50 -> 0.54.0 #55915
Conversation
a19a2d3
to
e097461
Compare
I've confirmed that this can successfully build the documentation repo for Hugo itself, so I'm assuming that it works. cc @schneefux for some input 😃 |
@GrahamcOfBorg build hugo |
I'll look into the macOS failure tomorrow. |
@sondr3 The aarch64 failure seems new as well: |
goPackagePath = "github.com/gobuffalo/envy"; | ||
fetch = { | ||
type = "git"; | ||
url = "https://github.com/gobuffalo/envy"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not found any references to this in the go code itself.
Do you know where this is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it is a test dependency only, the following will help:
subPackages = [ "." ];
this will make it build only the main package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I’ll look into it tomorrow. It wouldn’t build without them though.
I just built the package on my macOS machine and it built and worked, though it wouldn't work with the two manually added packages removed and
Not really sure what to make of the build errors on |
You can ignore the error on aarch64 as this is just a resource depletion on the builder. On macOS it seems like it did not had |
@sondr3 so you are saying this is a bug in |
I've asked about it being a bug in |
This doesn't seem to be working for me:
|
How are you installing the package? I just tried again on both my machines and a Docker image and it worked on all of them. The error also stems from one of the source files, which is strange as it means that there's something missing in the source code and not directly a build issue. In any case, this'll probably get resolved by #57080. |
@sondr3 it looks like this stems from me trying to overlay just this package from nixpkgs on top of the channel that my system's pointed at. I'm going to mark it down as user error :-) |
Motivation for this change
Upgrade Hugo from 0.50 to 0.54.0.
I had to do some manual adding of packages to the
deps.nix
file to get it to build, so I'm not really sure if the versions I've included forgobuffalo/envy
orjoho/godotenv
are exactly correct, but it built and ran fine on my computer.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)