Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inter: 3.1 -> 3.3 #55985

Closed
wants to merge 1 commit into from
Closed

inter: 3.1 -> 3.3 #55985

wants to merge 1 commit into from

Conversation

nathyong
Copy link
Contributor

The name of this font has also changed from "Inter UI" to simply "Inter"
as of version 3.3.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Feb 18, 2019

Can the font be used with the old font name, in other words is it worth adding a attrpath package alias?

@nathyong
Copy link
Contributor Author

As per the release notes at https://github.com/rsms/inter/releases it appears that the font name has changed completely. As for the testing package on my local machine, it only has fonts under the name "Inter".

@nathyong nathyong marked this pull request as ready for review February 28, 2019 21:35
@nathyong
Copy link
Contributor Author

As per the release notes at https://github.com/rsms/inter/releases it appears that the font name has changed completely. As for the testing package on my local machine, it only has fonts under the name "Inter".

@nathyong
inter: 3.1 -> 3.3
92642ec 
The name of this font has also changed from "Inter UI" to simply "Inter"
as of version 3.3.
@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

Hi @nathyong, thanks for contributing and sorry for the wait!

Would you mind adding a deprecation error in pkgs/top-level/aliases.nix for the old attribute name? Preferably with some minimal information that tells the users of the old package what they need to expect, ie. that both the package and font names changed. You can see examples of how to do this by searching for throw in that file. I think that would be the best possible user experience in this case.

Thanks again!

@srhb srhb self-requested a review March 16, 2019 16:14
@infinisil
Copy link
Member

Superseded by #57605

@infinisil infinisil closed this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@srhb srhb Awaiting requested review from srhb

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nathyong @ryantm @srhb @infinisil @GrahamcOfBorg