Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish: 3.0.0 -> 3.0.1 #55987

Merged
merged 1 commit into from Feb 18, 2019
Merged

fish: 3.0.0 -> 3.0.1 #55987

merged 1 commit into from Feb 18, 2019

Conversation

jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented Feb 18, 2019 •
edited

Motivation for this change

Update fish to 3.0.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Feb 18, 2019

@GrahamcOfBorg build fish

@etu
Copy link
Contributor

etu commented Feb 18, 2019

Changelog here: https://github.com/fish-shell/fish-shell/releases/tag/3.0.1

@etu etu merged commit 925b196 into NixOS:master Feb 18, 2019
@etu
Copy link
Contributor

etu commented Feb 18, 2019

@jethrokuan Thanks!

@jethrokuan jethrokuan deleted the update/fish branch February 18, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jethrokuan @etu @GrahamcOfBorg