Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why3: 1.1.1 -> 1.2.0 #55951

Merged
merged 1 commit into from Feb 25, 2019
Merged

why3: 1.1.1 -> 1.2.0 #55951

merged 1 commit into from Feb 25, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 17, 2019

Motivation for this change

Release notes: https://lists.gforge.inria.fr/pipermail/why3-club/2019-February/001850.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Feb 17, 2019

@GrahamcOfBorg build framac

@vbgl
Copy link
Contributor Author

vbgl commented Feb 20, 2019

@GrahamcOfBorg build framac

thoughtpolice
thoughtpolice approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but https://github.com/NixOS/nixpkgs/pull/55951/checks?check_run_id=66198611 indicates that mlgmpidl fails to build on aarch64-linux. Ideally we should restrict evaluation of that in a new PR.

Otherwise, feel free to merge, or I'll do it soon.

@vbgl
Copy link
Contributor Author

vbgl commented Feb 21, 2019

Thanks. Here is a PR that should address the issue of mlgmpidl on Aarch: #56154.

@vbgl vbgl merged commit 4266523 into NixOS:master Feb 25, 2019
@vbgl vbgl deleted the why3-1.2.0 branch February 25, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @thoughtpolice @GrahamcOfBorg