Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xapian: fix darwin build #55952

Merged
merged 1 commit into from Feb 22, 2019
Merged

xapian: fix darwin build #55952

merged 1 commit into from Feb 22, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Feb 17, 2019
LnL7
LnL7 reviewed Feb 18, 2019
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the other tests also tries to perform network requests (log).

/private/tmp/nix-build-xapian-1.4.10.drv-0/xapian-core-1.4.10/tests/.libs/apitest backend remotetcp_chert: All 290 tests passed, 5 skipped.
/private/tmp/nix-build-xapian-1.4.10.drv-0/xapian-core-1.4.10/tests/.libs/apitest total: 3257 tests passed, 1 failed, 46 skipped.

@flokli flokli mentioned this pull request Feb 19, 2019
Merged
10 tasks
@marsam
Copy link
Contributor Author

marsam commented Feb 20, 2019

Updated

@matthewbauer
Copy link
Member

@GrahamcOfBorg build xapian

@alyssais
Copy link
Member

Running test: bigoaddvalue1... FAILED
Test with 5000 repetitions took 0.021058 secs
Test with 50000 repetitions took 1.17001 secs

@marsam
Copy link
Contributor Author

marsam commented Feb 22, 2019

Updated, but I'm not sure why that test fail on borg
@GrahamcOfBorg build xapian

@alyssais
Copy link
Member

@GrahamcOfBorg build xapian

@alyssais
Copy link
Member

Updated, but I'm not sure why that test fail on borg

Probably because the test is to strict on timings, and borg was doing a few things at once.

@alyssais alyssais merged commit e2b9656 into NixOS:master Feb 22, 2019
@marsam marsam deleted the fix-xapian-darwin branch February 22, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@chaoflow chaoflow Awaiting requested review from chaoflow

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @matthewbauer @alyssais @LnL7 @GrahamcOfBorg