Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-control-center: point to gnome-session's libexecdir properly #55877

Merged
merged 1 commit into from Feb 17, 2019
Merged

gnome-control-center: point to gnome-session's libexecdir properly #55877

merged 1 commit into from Feb 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 16, 2019

Motivation for this change

Noticed while investigating some ultimately unrelated problem,
but seems like whatever it wants gnome-session libexecdir for
looking for it in a place that surely will not have those bits
is likely not the best.

(and if intentional should perhaps be documented)

If gnome3 maintainer thinks this is a clear win, great,
if it's a maze of questionableness then NP let's leave as-is :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 16, 2019
@worldofpeace
Copy link
Contributor

Seems this option is used for the info panel, and obviously the default when unset won't go very well.

Noticed while investigating some ultimately unrelated problem,
but seems like whatever it wants gnome-session libexecdir for
looking for it in a place that surely will not have those bits
is likely not the best.

Think that's what you meant @dtzWill?

@jtojnar
Copy link
Contributor

jtojnar commented Feb 16, 2019

For completeness, it is used in these places:

https://gitlab.gnome.org/GNOME/gnome-control-center/blob/1fed01f2cd95fbf21c4390fe5ea9326e217c0f96/panels/info/meson.build#L32
https://gitlab.gnome.org/GNOME/gnome-control-center/blob/1fed01f2cd95fbf21c4390fe5ea9326e217c0f96/panels/info/cc-info-overview-panel.c#L269

@jtojnar
Copy link
Contributor

jtojnar commented Feb 16, 2019

I would recommend using gnome-session from package arguments in the spirit of 606ceda#diff-0b2655b076a77e9d8a924c2ce49b2488

@worldofpeace worldofpeace force-pushed the fix/gnome-control-center-session-path-maybe branch from 52a180e to 22dac1e Compare February 17, 2019 03:38
@worldofpeace
Copy link
Contributor

I would recommend using gnome-session from package arguments in the spirit of 606ceda#diff-0b2655b076a77e9d8a924c2ce49b2488

Fixed that.

@worldofpeace worldofpeace merged commit 3eec4b5 into NixOS:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @worldofpeace @jtojnar @GrahamcOfBorg