Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unzip: patch CVE-2018-18384 #55927

Merged
merged 1 commit into from Feb 17, 2019
Merged

unzip: patch CVE-2018-18384 #55927

merged 1 commit into from Feb 17, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Feb 17, 2019

Patch from https://sourceforge.net/p/infozip/bugs/53/

Motivation for this change

Unpatched security vulnerability.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth changed the base branch from master to staging-next February 17, 2019 04:54
@vcunat vcunat merged commit 705167a into NixOS:staging-next Feb 17, 2019
@vcunat vcunat self-assigned this Feb 17, 2019
vcunat pushed a commit that referenced this pull request Feb 17, 2019
@delroth @vcunat
unzip: patch CVE-2018-18384 (PR #55927)
8d226d8 
Patch from https://sourceforge.net/p/infozip/bugs/53/

(cherry picked from commit 705167a)
@vcunat vcunat added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 17, 2019
@vcunat vcunat mentioned this pull request Feb 17, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @vcunat @GrahamcOfBorg