New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/icingaweb2: Init the module #55957
Conversation
The module is indeed very large but allows configuring every aspect of icingaweb2. The built-in monitoring module is in an own file because there are actually more (third-party) modules and this structure means every module can get an own file.
test something to ensure module evaluates when not enabled @GrahamcOfBorg test env |
@ryantm That was a bit fast of a merge imo, such big changes warrant a bigger window for discussion, 1 hour is not enough I'm not a fan of having huge number of options. See what I did in #45470 instead, which has multiple advantages (and some disadvantages) to this way. Advantages:
Disadvantages:
(This is similar to just a string based option, but that wouldn't support proper merging behavior and have no guaranteed syntax correctness.) |
@infinisil sorry. I'll give more time next time. |
@infinisil do you want me to rewrite the configuration stuff? |
Nah I'm fine with it, it's merged already and the work is done. Unless you prefer my suggestion as well and don't mind changing it again, in which case I'll be happy to work with you towards that solution (and reverting this PR meanwhile), up to you. In any case this way is what lots of other people are doing too (having dozens of options for every single configuration option). I just hope that this idea of only a single config option will be used more in the future. |
The module is indeed very large but allows configuring every aspect of
icingaweb2. The built-in monitoring module is in an own file because
there are actually more (third-party) modules and this structure means
every module can get an own file.
Motivation for this change
I'm using icingaweb2
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)