Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubioath-desktop: 3.1.0 -> 4.3.4; yubikey-manager: 1.0.1 -> 2.0.0 #54215

Merged
merged 5 commits into from Jan 17, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 17, 2019

Motivation for this change

yubioath-desktop did not work for me before this upgrade.
I also documented the steps needed in the wiki: https://nixos.wiki/wiki/Yubikey
I tested both the CCID mode and the OTP mode.

cc @bjornfor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only tested applications (no code-review), both build and work (with my yubikey)

@Mic92 Mic92 merged commit fdfd5ba into NixOS:master Jan 17, 2019
@Mic92 Mic92 deleted the yubikey branch January 17, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants