Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exfat-nofuse: backport unbreak for 4.18 and 4.20 #54228

Merged
merged 1 commit into from Jan 18, 2019

Conversation

schmittlauch
Copy link
Member

(cherry picked from commit eac6725)

Motivation for this change

backport of #53696 to fix #53678

This builds fine, but I found no way of actually testing this as even mount-exfat used exfat-fuse, even after a modprobe exfat. Any ideas, @makefu? (exfat is not in my sytem profile, but exfat-utils is)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • rebuilt system on this commit of nixpkgs using nixos-rebuild switch

@makefu
Copy link
Contributor

makefu commented Jan 18, 2019

mount -t exfat should use the non-fuse module (check dmesg) 👍

@Mic92 Mic92 merged commit b3f403b into NixOS:release-18.09 Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants