Fix #6145: Prevent ships without valid orders from moving #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested the pathological case of a dock with the docking area at the top tile, still works.
|
|
I still stand by my comment that making ships stop is inconsistent with everything else. |
|
However, stopped ships don't block track/roads the same way trains and road vehicles do, but on the contrary have much greater risk of getting further lost if they just roam randomly. |
|
We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles! |
nielsmh
force-pushed
the
stop-orderless-ships
branch
from
b535552
to
ce43e32
Compare
|
I am -1 for the highly personal reason that I often use orderless ships to test newgrfs :D |
|
#6784 was merged so this is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #6784, at least in some respects.
This also attempts to solve the problem of order cycling (current order going around the orders list) if all the stops on the orders list are deleted, but their station sign still remains.