Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome-sound-recorder: 3.28.1 -> 3.28.2 #54206

Merged
merged 1 commit into from Jan 18, 2019
Merged

gnome3.gnome-sound-recorder: 3.28.1 -> 3.28.2 #54206

merged 1 commit into from Jan 18, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gnome-sound-recorder/versions.

meta.description for gnome3.gnome-sound-recorder is: '"A simple and modern sound recorder"'.

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/zi0yrxms9cw4mhm1fjwaxa7lpi4pmkwy-gnome-sound-recorder-3.28.2/bin/.gnome-sound-recorder-wrapped had a zero exit code or showed the expected version
  • /nix/store/zi0yrxms9cw4mhm1fjwaxa7lpi4pmkwy-gnome-sound-recorder-3.28.2/bin/gnome-sound-recorder passed the binary check.
  • 1 of 2 passed binary check by having a zero exit code.
  • 0 of 2 passed binary check by having the new version present in output.
  • found 3.28.2 with grep in /nix/store/zi0yrxms9cw4mhm1fjwaxa7lpi4pmkwy-gnome-sound-recorder-3.28.2
  • directory tree listing: https://gist.github.com/da9138794ff84013393105f4c57e7069
  • du listing: https://gist.github.com/9dba5f8b038a4eeca6732d632f23fa94
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gnome3.gnome-sound-recorder

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/zi0yrxms9cw4mhm1fjwaxa7lpi4pmkwy-gnome-sound-recorder-3.28.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A gnome3.gnome-sound-recorder https://github.com/r-ryantm/nixpkgs/archive/4624693467239c584a20949bac46fb9fda944257.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/zi0yrxms9cw4mhm1fjwaxa7lpi4pmkwy-gnome-sound-recorder-3.28.2
ls -la /nix/store/zi0yrxms9cw4mhm1fjwaxa7lpi4pmkwy-gnome-sound-recorder-3.28.2/bin

cc @lethalman @jtojnar @hedning for testing.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 17, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Jan 17, 2019

https://gitlab.gnome.org/GNOME/gnome-sound-recorder/blob/3.28.2/NEWS#L1

@jtojnar jtojnar force-pushed the auto-update/gnome-sound-recorder branch from 4624693 to 9ba22f1 Compare January 17, 2019 20:59
@jtojnar
Copy link
Contributor

jtojnar commented Jan 17, 2019

Hmm, crashes for me when I try to play a recording:

** (org.gnome.SoundRecorder:22484): CRITICAL **: 21:58:25.769: g_object_info_get_n_fields: assertion 'info != NULL' failed
**
Gjs:ERROR:gi/object.cpp:481:bool ObjectInstance::field_getter_impl(JSContext*, JS::HandleObject, JS::HandleString, JS::MutableHandleValue): assertion failed: (field)
fish: “result/bin/gnome-sound-recorder” terminated by signal SIGABRT (Abort)

but at least it no longer crashes at start-up (probably unnoticed when we upgraded gjs):

(org.gnome.SoundRecorder:23787): Gjs-CRITICAL **: 21:59:29.293: JS ERROR: SyntaxError: missing ) after catch @ resource:///org/gnome/SoundRecorder/js/listview.js:114

@hedning
Copy link
Contributor

hedning commented Jan 17, 2019

Getting the same crash, recording is fine, but playing not.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 17, 2019

https://gitlab.gnome.org/GNOME/gnome-sound-recorder/issues/39 (confidential) says it is fixed on master but I can still reproduce it there. Currently trying to obtain backtrace that does not suck.

@jtojnar
gnome3.gnome-sound-recorder: 3.28.1 -> 3.28.2
9c23304 
Also adding a patch that fixes crash when trying to play recordings.
@jtojnar jtojnar force-pushed the auto-update/gnome-sound-recorder branch from 9ba22f1 to 9c23304 Compare January 18, 2019 00:47
@jtojnar
Copy link
Contributor

jtojnar commented Jan 18, 2019

Pushed a patch upstream.

@jtojnar jtojnar merged commit 7cc983e into NixOS:master Jan 18, 2019
@r-ryantm r-ryantm deleted the auto-update/gnome-sound-recorder branch January 25, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @jtojnar @hedning @GrahamcOfBorg