Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: sphinxcontrib-wavedrom: init at 2.0.0, wavedrom: init at 0.1 #54234

Closed
wants to merge 3 commits into from
Closed

pythonPackages: sphinxcontrib-wavedrom: init at 2.0.0, wavedrom: init at 0.1 #54234

wants to merge 3 commits into from

Conversation

clacke
Copy link
Contributor

@clacke clacke commented Jan 18, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clacke clacke requested a review from FRidh as a code owner January 18, 2019 01:01
@FRidh
Copy link
Member

FRidh commented Jan 18, 2019

Sphinx update is already in staging. Rebase onto staging.

@clacke clacke changed the base branch from master to staging January 24, 2019 07:13
@clacke
Copy link
Contributor Author

clacke commented Jan 29, 2019

Does not build on staging because dejagnu doesn't. Do we file issues against staging, or is this tracked somewhere else?

@clacke clacke changed the title python: sphinxcontrib-wavedrom: init at 2.0.0, Sphinx: 1.7.9 -> 1.8.3, wavedrom: init at 0.1 pythonPackages.sphinxcontrib-wavedrom: init at 2.0.0, pythonPackages.wavedrom: init at 0.1 Feb 19, 2019
@clacke clacke changed the title pythonPackages.sphinxcontrib-wavedrom: init at 2.0.0, pythonPackages.wavedrom: init at 0.1 pythonPackages: sphinxcontrib-wavedrom: init at 2.0.0, wavedrom: init at 0.1 Feb 19, 2019
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

Are there any updates on this pull request, please?

@ttuegel ttuegel removed their request for review September 28, 2019 11:58
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

Nothing happening so closing.

@FRidh FRidh closed this Feb 9, 2020
@Spaqin
Copy link

Spaqin commented Feb 15, 2022

Any plans on integrating sphinxcontrib-wavedrom 3.0+ to nixpkgs? Especially since wavedrom is already a part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@basvandijk basvandijk Awaiting requested review from basvandijk

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@clacke @FRidh @mmahut @Spaqin @ryantm @GrahamcOfBorg