Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: 8.5 -> 8.6 #54202

Merged
merged 2 commits into from Jan 17, 2019
Merged

sage: 8.5 -> 8.6 #54202

merged 2 commits into from Jan 17, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 17, 2019 •
edited

Motivation for this change

This was a quick release cycle. Thats partly due to upstream wanting to get something released before the debian package freeze.

Because this was so quick, my time was limited and I had some issues with the betas, there was no beta tracking this time. Straight to the release.

With this release we can finally get rid of libgap. Now the only remaining dependency sage needs to downgrade is ecl and people are working on that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
sage: 8.5 -> 8.6
e379ee6
@timokau
libgap, gap-libgap-compatible: remove
471ba67 
They were only used by sage, which now (since version 8.6) uses gaps own
(new) libgap.
@timokau timokau merged commit 73368f4 into NixOS:master Jan 17, 2019
@timokau timokau deleted the sage-8.6 branch January 17, 2019 20:12
vcunat added a commit that referenced this pull request Sep 8, 2019
@vcunat
libgap: remove unreachable path
252a30e 
This was clearly forgotten in 471ba67 #54202.
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@vcunat @dtzWill
libgap: remove unreachable path
8742bab 
This was clearly forgotten in 471ba67 NixOS#54202.

(cherry picked from commit 252a30e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg