Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Scribus has no desktop icon currently. I’ve checked in the source tarball, and there is nothing good here: only a low-res icon.
Things done
I’ve got a SVG file from this page on the Scribus Wiki and edited it a bit to get a square file and center the circle. Since the icon is not present in the source tarball, I’ve put this resource in
nixpkgs
. I’m not sure if it is a good thing or not, let me know if you have a better idea on how to do this.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)I have also checked the possibility to backport it to
release-18.09
: it would require one more action to create the.desktop
file since Scribus 1.4.6 does not include one. I have already defined one for a wrapper in my Nix channel so I could port it easily torelease-18.09
if it is OK to proceed.