Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scribus: Add an icon #53456

Merged
merged 2 commits into from Jan 12, 2019
Merged

scribus: Add an icon #53456

merged 2 commits into from Jan 12, 2019

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented Jan 5, 2019

Motivation for this change

Scribus has no desktop icon currently. I’ve checked in the source tarball, and there is nothing good here: only a low-res icon.

Things done

I’ve got a SVG file from this page on the Scribus Wiki and edited it a bit to get a square file and center the circle. Since the icon is not present in the source tarball, I’ve put this resource in nixpkgs. I’m not sure if it is a good thing or not, let me know if you have a better idea on how to do this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I have also checked the possibility to backport it to release-18.09: it would require one more action to create the .desktop file since Scribus 1.4.6 does not include one. I have already defined one for a wrapper in my Nix channel so I could port it easily to release-18.09 if it is OK to proceed.


let
icon = ./icon.svg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we download this from somewhere? Ideally it would be included in the the src

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the original SVG file is here, but it is not square nor centered so I’ve edited it. If you know how we can script that on the SVG file or when converting it to PNG we are good, but else we need to use this custom file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about supplying icon.svg as a gist? This way it would not pollute the Nixpkgs source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erictapen Nice idea, I’ll do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I can rebase and squash the commit if needed.

@flokli flokli merged commit 6ca8443 into NixOS:master Jan 12, 2019
@ejpcmac ejpcmac deleted the fix-scribus-icon branch January 13, 2019 06:34
voobscout pushed a commit to voobscout/nixpkgs that referenced this pull request Jan 16, 2019
* scribus: Add an icon

* scribus: Put the icon SVG in a Gist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants