New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neovim-qt: wrap in separate derivation #53447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone should make sure I didn't mess up the darwin wrapper @NixOS/darwin-maintainers. You can test ist by building and executing neovim-qt.override {
neovim = neovim.override {
configure = {
customRC = ''
normal iIt worked!
'';
};
};
} Which should then start neovim-qt and show the text "It worked!". |
timokau
force-pushed
the
neovim-qt-wrapper
branch
from
January 5, 2019 13:33
9e2a87f
to
de8048a
Compare
CC @peterhoeg |
@GrahamcOfBorg build neovim-qt |
timokau
force-pushed
the
neovim-qt-wrapper
branch
from
January 5, 2019 14:21
de8048a
to
59368e3
Compare
grahamc
reviewed
Jan 5, 2019
timokau
force-pushed
the
neovim-qt-wrapper
branch
from
January 5, 2019 14:54
59368e3
to
3c90f15
Compare
bhipple
reviewed
Jan 5, 2019
This makes it possible to swap out the (wrapped) neovim without recompiling neovim-qt. In particular, the user can use `neovim.override` to configure their neovim and then use that same configuration for neovim-qt, without having to give up binary caching.
timokau
force-pushed
the
neovim-qt-wrapper
branch
from
January 6, 2019 09:56
3c90f15
to
c52c4a0
Compare
The new darwin failure is unrelated (caused by a cups failure). |
Does anyone have objections to merging this? (@peterhoeg?) |
peterhoeg
approved these changes
Jan 8, 2019
timokau
added a commit
to timokau/nixpkgs
that referenced
this pull request
Jan 10, 2019
My recent change in NixOS#53447 caused neovim-qt to no longer be recognized as a desktop application.
10 tasks
timokau
added a commit
that referenced
this pull request
Jan 10, 2019
My recent change in #53447 caused neovim-qt to no longer be recognized as a desktop application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This makes it possible to swap out the (wrapped) neovim without
recompiling neovim-qt. In particular, the user can use
neovim.override
to configure their neovim and then use that same configuration for
neovim-qt, without having to give up binary caching.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)