Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim-qt: wrap in separate derivation #53447

Merged
merged 2 commits into from Jan 8, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 5, 2019

Motivation for this change

This makes it possible to swap out the (wrapped) neovim without
recompiling neovim-qt. In particular, the user can use neovim.override
to configure their neovim and then use that same configuration for
neovim-qt, without having to give up binary caching.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Jan 5, 2019

Someone should make sure I didn't mess up the darwin wrapper @NixOS/darwin-maintainers. You can test ist by building and executing

neovim-qt.override {
  neovim = neovim.override {
    configure = {
      customRC = ''
        normal iIt worked!
      '';
    };
  };
}

Which should then start neovim-qt and show the text "It worked!".

@timokau
Copy link
Member Author

timokau commented Jan 5, 2019

CC @peterhoeg

@timokau
Copy link
Member Author

timokau commented Jan 5, 2019

@GrahamcOfBorg build neovim-qt

This makes it possible to swap out the (wrapped) neovim without
recompiling neovim-qt. In particular, the user can use `neovim.override`
to configure their neovim and then use that same configuration for
neovim-qt, without having to give up binary caching.
@timokau
Copy link
Member Author

timokau commented Jan 6, 2019

The new darwin failure is unrelated (caused by a cups failure).

@timokau
Copy link
Member Author

timokau commented Jan 8, 2019

Does anyone have objections to merging this? (@peterhoeg?)

@peterhoeg peterhoeg merged commit 15c8362 into NixOS:master Jan 8, 2019
@timokau timokau deleted the neovim-qt-wrapper branch January 8, 2019 17:02
timokau added a commit to timokau/nixpkgs that referenced this pull request Jan 10, 2019
My recent change in NixOS#53447 caused neovim-qt to no longer be recognized
as a desktop application.
timokau added a commit that referenced this pull request Jan 10, 2019
My recent change in #53447 caused neovim-qt to no longer be recognized
as a desktop application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants