Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/systemd-udev-settle: don't restart on upgrades #53446

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 5, 2019

The idea is that we only need this target during boot,
however there is no point on restarting it on every upgrade.

This hopefully fixes #21954

Please let me test this for a while!

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The idea is that we only need this target during boot,
however there is no point on restarting it on every upgrade.

This hopefully fixes NixOS#21954
@peterhoeg
Copy link
Member

While at it, how about adding a configuration setting for completely disabling udev-settle?

@Mic92 Mic92 merged commit ba9f589 into NixOS:master Jan 8, 2019
@Mic92 Mic92 deleted the systemd-udev-settle branch January 8, 2019 12:05
@Mic92
Copy link
Member Author

Mic92 commented Jan 8, 2019

@peterhoeg I would like to keep this out of scope of this pull-request.

@Mic92
Copy link
Member Author

Mic92 commented Jan 8, 2019

I think this change is safe to backport.

@peterhoeg
Copy link
Member

Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos-rebuild switch produces warnings about systemd-udev-settle service
3 participants