-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when craft breaks in atmosphere with explosions in KSP 1.3.1 with RP-1 (Erdos) #2056
Comments
The relevant source code lines looks to be: auto const a = intrinsic_force_ / mass_;
// NOTE(phl): |a| used to be captured by copy below, which is the logical
// thing to do. However, since it contains an |R3Element|, it must be
// aligned on a 16-byte boundary. Unfortunately, VS2015 gets confused and
// aligns the function object on an 8-byte boundary, resulting in an
// addressing fault. With a reference, VS2015 knows what to do.
auto const intrinsic_acceleration = [&a](Instant const& t) { return a; };
CHECK_OK(ephemeris_->FlowWithAdaptiveStep(
history_.get(),
intrinsic_acceleration,
t,
adaptive_step_parameters_,
Ephemeris<Barycentric>::unlimited_max_ephemeris_steps,
/*last_point_only=*/false));
psychohistory_ = history_->NewForkAtLast(); |
The last line in your stack trace is indeed Principia/ksp_plugin/pile_up.cpp Lines 372 to 378 in 3e2334a
LogMessageFatal , this looks like a CHECK_OK failure (FlowWithAdaptiveStep returned an erroneous status).
Can you give us the corresponding INFO log (https://github.com/mockingbirdnest/Principia/wiki/Installing,-reporting-bugs,-and-frequently-asked-questions#windows-dialog-box-or-sigabrt)? Given that this is a reentry, Principia/physics/ephemeris_body.hpp Line 476 in 3e2334a
We should handle |
Crash minidump with heap and glog's for 2018-12-30 are available at |
Given the intermittent nature of the issue, and not all disintegrations ending up in KSP crash, I suspect some form of timing / race condition when vehicle splits in multiple piece after fuel tank overheated and exploded. As I've never seen this with last 1.2.2 version, I speculate, handling of objects in atmosphere made it much more likely. |
Interesting; the log file ends with a singularity (
Decoded stack (same as yours above):
This probably means that we have calculated that the vessel should have gone very close to the centre of the Earth (making it impossible for us to integrate its motion further), but KSP did not notice the collision and failed to kill the vessel.
I think so too (you can get closer to the ground, making it more likely to be about to crash or run into the singularity). |
@nikolain: The change in #2064 removes the There is a |
Awesome. I'll give the changed code a try (either after Feb 4th with official build) or in private build if I get to it. |
No news is good news. Closing. |
When craft starts breaking apart and explode on atmospheric reentry, there is a chance for Principia Erdos to crash. This happens with <10% of such reentries.
Native call stack:
The text was updated successfully, but these errors were encountered: