Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dockerfile-parse: init at 0.0.13 #53422

Merged
merged 1 commit into from Mar 14, 2019
Merged

pythonPackages.dockerfile-parse: init at 0.0.13 #53422

merged 1 commit into from Mar 14, 2019

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Jan 4, 2019 •
edited

Motivation for this change

A generally useful library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leenaars leenaars requested a review from FRidh as a code owner January 4, 2019 22:28
FRidh
FRidh previously requested changes Jan 5, 2019
View reviewed changes
pkgs/development/python-modules/python-snappy/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

Tests fail for python-snappy.

test_valid_compressed_buffer (test_snappy.SnappyValidBufferTest) ... ok

======================================================================
ERROR: snappy_cffi (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: snappy_cffi
Traceback (most recent call last):
  File "/nix/store/4ag8gng51y7yw6nr3imwyppqfci3j643-python3-3.7.2/lib/python3.7/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/build/python-snappy-0.5.3/snappy/snappy_cffi.py", line 3, in <module>
    from ._snappy_cffi import ffi, lib
ModuleNotFoundError: No module named 'snappy._snappy_cffi'


----------------------------------------------------------------------
Ran 27 tests in 2.127s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=27 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=27 errors=1 failures=0>
builder for '/nix/store/vs08jm26i6rzidcpyvd67ww0whcwd9kp-python3.7-python-snappy-0.5.3.drv' failed with exit code 1

@leenaars
Copy link
Contributor Author

leenaars commented Jan 6, 2019 •
edited

@FRidh: is there a difference how the propagatedBuildInputs between Python2 and Python3 are handled? Because this build just fine with Python 2.7, and with the previous incarnations I had (that included pythonPackages, which you recommended not to use) in Python3.7 everything also worked just as well? So behaviour seems inconsistent ...

@FRidh
Copy link
Member

FRidh commented Jan 6, 2019

pythonPackages refers to top-level Python packages, which is python27Packages.

worldofpeace
worldofpeace suggested changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually in time passing python-snappy has already been packaged.
Please ignore reviews for that package, and remove it from this pr.

@leenaars leenaars changed the title pythonPackages.python-snappy: init at 0.5.3 pythonPackages.dockerfile-parse: init at 0.0.13 Mar 13, 2019
@leenaars
Copy link
Contributor Author

leenaars commented Mar 13, 2019 •
edited

@worldofpeace: removed python-snappy, now just one module. Renamed and fixed the semi-colon issue.

@ryantm ryantm merged commit 2e76e35 into NixOS:master Mar 14, 2019
@worldofpeace
Copy link
Contributor

Thank you @leenaars for contributing ❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leenaars @worldofpeace @FRidh @ryantm @GrahamcOfBorg