Skip to content

nixos/duplicity: init #53463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

nixos/duplicity: init #53463

merged 1 commit into from
Mar 4, 2019
+142 −0

Conversation

OlivierMarty
Copy link

Add a simple module that wrap duplicity in a systemd service.

I've used this module for a while on my server. It's handy to set services.duplicity.include in multiple places of my nix configuration, next to where the directories are used. It could help other duplicity users.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 5, 2019
@OlivierMarty OlivierMarty force-pushed the master branch 2 times, most recently from 8553181 to c12a5e1 Compare January 6, 2019 15:49
infinisil
infinisil requested changes Jan 8, 2019
View reviewed changes
infinisil
infinisil requested changes Jan 24, 2019
View reviewed changes
nixos/modules/services/backup/duplicity.nix Outdated
'';

environment = {
GNUPGHOME=stateDirectory;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for? In any case formatting should be fixed, environment.GNUPGHOME = stateDirectory;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicity uses GPG which stores files in the home directory, but it's read only. I think that the state directory is a good fit.
I replaced GNUPGHOME by HOME (it supersedes it).

nixos/duplicity: init
7a87866 
Add a simple module that wrap duplicity in a systemd service.
@OlivierMarty
Copy link
Author

Gentle ping?

@infinisil infinisil merged commit 8c4babb into NixOS:master Mar 4, 2019
@infinisil
Copy link
Member

Looking good thanks :)

@OlivierMarty
Copy link
Author

Thanks!

@OlivierMarty OlivierMarty mentioned this pull request Mar 4, 2019
Closed
8 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OlivierMarty @infinisil @GrahamcOfBorg @Janik-Haag