Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qMasterPassword: init at 1.2.2 #53452

Merged
merged 2 commits into from Jan 20, 2019
Merged

Conversation

tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented Jan 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tadeokondrak
Copy link
Member Author

Does not build on Darwin/macOS yet

@veprbl
Copy link
Member

veprbl commented Jan 20, 2019

@GrahamcOfBorg build qMasterPassword

@veprbl veprbl merged commit 6fc8992 into NixOS:master Jan 20, 2019
@tadeokondrak tadeokondrak deleted the init-qmasterpassword branch January 20, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants