fwupd: 1.2.1 -> 1.2.3 #53425
Merged
fwupd: 1.2.1 -> 1.2.3 #53425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jan 5, 2019
| }; | ||
|
|
||
| outputs = [ "out" "lib" "dev" "devdoc" "man" "installedTests" ]; | ||
| outputs = [ "out" "dev" "devdoc" "man" "installedTests" ]; |
There was a problem hiding this comment.
Weird, I am getting the circular dependency but cannot grep the lib references in the out
|
|
|
I think they from the wrapped binaries,
so maybe your grep invocation wasn't checking 'hidden' files?
…On Fri, 04 Jan 2019 16:06:42 -0800, Jan Tojnar ***@***.***> wrote:
jtojnar commented on this pull request.
> };
- outputs = [ "out" "lib" "dev" "devdoc" "man" "installedTests" ];
+ outputs = [ "out" "dev" "devdoc" "man" "installedTests" ];
Weird, I am getting the circular dependency but cannot `grep` the `lib` references in the `out`
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#53425 (review) part: text/html
|
|
Is seems like the issue is that the newly added plug-ins are in $ git checkout channels/nixos-unstable-small
$ du --human-readable $(nix-build -A fwupd.all) --summarize
2,0M /nix/store/d92li0fnkyxdyr98xccwxiw2pm2l4h8p-fwupd-1.2.1
3,7M /nix/store/cyjma8cf68lg1rcdli55w61rlhw8lnky-fwupd-1.2.1-lib
272K /nix/store/dh33r3xnykrhjh0nvilfaxwf6qsidslq-fwupd-1.2.1-dev
976K /nix/store/502c6qikkfq08sy71g86bac3wqbc1kwf-fwupd-1.2.1-devdoc
24K /nix/store/rvvrly90n0c0gqw2dqmc2w9jisdl0va4-fwupd-1.2.1-man
52K /nix/store/0fvw17z4w3rv0kqxcpbmi43rm1vcxs81-fwupd-1.2.1-installedTests
$ nix path-info -S /nix/store/d92li0fnkyxdyr98xccwxiw2pm2l4h8p-fwupd-1.2.1 /nix/store/cyjma8cf68lg1rcdli55w61rlhw8lnky-fwupd-1.2.1-lib
/nix/store/cyjma8cf68lg1rcdli55w61rlhw8lnky-fwupd-1.2.1-lib 232096728
/nix/store/d92li0fnkyxdyr98xccwxiw2pm2l4h8p-fwupd-1.2.1 570954824
$ git checkout dtzWill/update/fwupd-1.2.3
$ du --human-readable $(nix-build -A fwupd.all) --summarize
11M /nix/store/79dn0g3wnnghk4bx6b75vxdhmmfkamg0-fwupd-1.2.3
272K /nix/store/9aphq7lr2k6rnim1i843n0hgli2if01y-fwupd-1.2.3-dev
992K /nix/store/s23vnalm4gp0bgh1h6hbnjpcankiv7r8-fwupd-1.2.3-devdoc
24K /nix/store/ahppw5jh7nbib2yhx76cxbaycf0rg1bm-fwupd-1.2.3-man
52K /nix/store/4z7zwmnnl8mvk7w8x52qcim9ncg8lncr-fwupd-1.2.3-installedTests
$ nix path-info -S /nix/store/79dn0g3wnnghk4bx6b75vxdhmmfkamg0-fwupd-1.2.3
/nix/store/79dn0g3wnnghk4bx6b75vxdhmmfkamg0-fwupd-1.2.3 575884792 |
|
Hmm, well that's easy enough to fix (pushed commit doing so).
What's the goal with the separate "lib" output here, anyway?
I'm not sure what uses fwupd (gnome-software?),
would this maybe make libfwupd users have difficulties
using the plugins?
…-----
(mini-rant, don't mind me...)
BTW **gah** at another piece of software with a dynamic plugin system
that is, in practice, entirely resolved at compile-time...
and the rest of the use cases are all install/deploy-time.
So no reason to have search directories of shared libraries
that are totally-going-to-work-TM,
concern yourself with how plugins are 'discovered';
similarly no need for blacklist configuration files...
just include the ones you need?
(best way to blacklist code is to never have it on your computer in the
first place :P)
O:)
On Fri, 04 Jan 2019 18:38:34 -0800, Jan Tojnar ***@***.***> wrote:
Is seems like the issue is that the newly added plug-ins are in `lib` output instead of `out`.
```ShellSession
$ git checkout channels/nixos-unstable-small
$ du --human-readable $(nix-build -A fwupd.all) --summarize
2,0M /nix/store/d92li0fnkyxdyr98xccwxiw2pm2l4h8p-fwupd-1.2.1
3,7M /nix/store/cyjma8cf68lg1rcdli55w61rlhw8lnky-fwupd-1.2.1-lib
272K /nix/store/dh33r3xnykrhjh0nvilfaxwf6qsidslq-fwupd-1.2.1-dev
976K /nix/store/502c6qikkfq08sy71g86bac3wqbc1kwf-fwupd-1.2.1-devdoc
24K /nix/store/rvvrly90n0c0gqw2dqmc2w9jisdl0va4-fwupd-1.2.1-man
52K /nix/store/0fvw17z4w3rv0kqxcpbmi43rm1vcxs81-fwupd-1.2.1-installedTests
$ nix path-info -S /nix/store/d92li0fnkyxdyr98xccwxiw2pm2l4h8p-fwupd-1.2.1 /nix/store/cyjma8cf68lg1rcdli55w61rlhw8lnky-fwupd-1.2.1-lib
/nix/store/cyjma8cf68lg1rcdli55w61rlhw8lnky-fwupd-1.2.1-lib 232096728
/nix/store/d92li0fnkyxdyr98xccwxiw2pm2l4h8p-fwupd-1.2.1 570954824
$ git checkout dtzWill/update/fwupd-1.2.3
$ du --human-readable $(nix-build -A fwupd.all) --summarize
11M /nix/store/79dn0g3wnnghk4bx6b75vxdhmmfkamg0-fwupd-1.2.3
272K /nix/store/9aphq7lr2k6rnim1i843n0hgli2if01y-fwupd-1.2.3-dev
992K /nix/store/s23vnalm4gp0bgh1h6hbnjpcankiv7r8-fwupd-1.2.3-devdoc
24K /nix/store/ahppw5jh7nbib2yhx76cxbaycf0rg1bm-fwupd-1.2.3-man
52K /nix/store/4z7zwmnnl8mvk7w8x52qcim9ncg8lncr-fwupd-1.2.3-installedTests
$ nix path-info -S /nix/store/79dn0g3wnnghk4bx6b75vxdhmmfkamg0-fwupd-1.2.3
/nix/store/79dn0g3wnnghk4bx6b75vxdhmmfkamg0-fwupd-1.2.3 575884792
```
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#53425 (comment) part: text/html
|
Drop lib output to avoid cycle.
Don't add the testing "webcam" device, which is unexpected to see when querying what devices fwupd believes exist :). Won't change behavior for anyone defining the blacklistPlugin option already, but doesn't seem worth making more complicated.
jtojnar
force-pushed
the
update/fwupd-1.2.3
branch
from
f26f1cf
to
dd06999
Compare
|
Yup, gnome-software is what I was concerned about. Plug-ins should work fine, as the I fixed the location of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The fwupd NixOS test passes :).
Also this disables the test plugin by default
for a slightly improved default experience.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)