Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: buildPython*: enable strictDeps #53445

Closed
wants to merge 1 commit into from
Closed

WIP: buildPython*: enable strictDeps #53445

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 5, 2019

Motivation for this change

Enable strictDeps to check whether we're using (native)BuildInputs correctly or not. Fixing the fall-out of enabling this would be a huge step forward for cross-compiling Python packages.

Python cross-compilation issue #53320

This PR includes a stdenv change for which a separate PR exists #53440. When that's accepted, the majority of changes will be ensuring the test dependencies are in the checkInputs.

To do:

  • document strictDeps is enabled and clarify the inputs situation regarding Python packages
  • changelog
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 5, 2019

All in favor for that. This should be also mentioned in the release notes as it affects also user packages.

@FRidh FRidh changed the title buildPython*: enable strictDeps WIP: buildPython*: enable strictDeps Jan 5, 2019
@FRidh FRidh force-pushed the python-unstable branch 3 times, most recently from 59a0f73 to 694f44a Compare January 5, 2019 17:39
@FRidh FRidh mentioned this pull request Jan 6, 2019
10 tasks
@FRidh
Copy link
Member Author

FRidh commented Jan 17, 2019

I need the python-unstable branch for something else so closing this now in favor of #54182.

@FRidh FRidh closed this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants