nixos/earlyoom: add notificationsCommand option #53444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Jan 8, 2019
| @@ -63,6 +63,15 @@ in | |||
| Enable debugging messages. | |||
| ''; | |||
| }; | |||
|
|
|||
| notificationsCommand = mkOption { | |||
| type = types.string; | |||
There was a problem hiding this comment.
I've changed the type. What's the difference? Seems to do something with how it's merged?
There was a problem hiding this comment.
Yeah, types.string concatenates strings for merging, which is almost never what you want, so that's why it's deprecated.
|
|
||
| notificationsCommand = mkOption { | ||
| type = types.string; | ||
| default = null; |
There was a problem hiding this comment.
Can you provide an example in the example attribute?
There was a problem hiding this comment.
I've added example from earlyoom's readme. I didn't want to add it because it's fairly convoluted.
wedens
force-pushed
the
earlyoom-notifications
branch
from
99ff817
to
e545c64
Compare
infinisil
requested changes
Jan 8, 2019
| example = "sudo -u example_user DISPLAY=:0 DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus notify-send"; | ||
| description = '' | ||
| Command used to send notifications. | ||
| See https://github.com/rfjakob/earlyoom#notifications for details. |
There was a problem hiding this comment.
Oh one more thing, you need to wrap the link in <link xlink:href="https://..."/> to make it show up correctly in the rendered docs.
Add option for specifying command that will be used for sending notifications. See https://github.com/rfjakob/earlyoom#notifications for details.
wedens
force-pushed
the
earlyoom-notifications
branch
from
e545c64
to
5798d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add option for specifying command that will be used for sending notifications.
See https://github.com/rfjakob/earlyoom#notifications for details.
Also there is now a script in the repo for sending notifications to all users. When a new version of earlyoom will be released, perhaps it'll make sense to add an option to use this script.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)