SCI32: Cleanup QFG4 script patches #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vhati
commented
Jan 5, 2019
•
Vhati
commented
- Trivially revises comments and var names for consistency.
- Changes hardcoded selector bytes to macros.
- Confirms early patches against editions not tested at the time.
- Combines two TRAP array patches (commits 6c44106, aceb528) into one.
- Even though editions had different class numbers, ByteArray was consistently IntArray+2.
- I fixed a couple of inaccurate opcode comments in GK1 as well.
Vhati
force-pushed
the
qfg4_code_cleanup
branch
from
2c0ec42
to
eb71d20
Compare
Vhati
force-pushed
the
qfg4_code_cleanup
branch
from
eb71d20
to
21e4f3a
Compare
|
Nice work, merging |
ccawley2011
pushed a commit
to ccawley2011/scummvm
that referenced
this pull request
Oct 10, 2020
STARK: Implement keyboard bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.