Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/types: make _module.args a types.args #53443

Closed
wants to merge 1 commit into from
Closed

lib/types: make _module.args a types.args #53443

wants to merge 1 commit into from

Conversation

furrycatherder
Copy link
Contributor

@furrycatherder furrycatherder commented Jan 5, 2019 •
edited

Currently, _module.args is merged according to the default rules,
which produces interesting results if we try to assign an attrset with
_module.args.name to an option with type attrsOf (submodule foo)
(i.e., one that already has name defined).

This adds a new type args that will just merge the topmost definition.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@furrycatherder
lib/types: make _module.args a types.args
2c3796f 
Currently, `_module.args` is merged according to the default rules,
which produces interesting results if we try to assign an attrset with
`_module.args.name` to an option with type `attrsOf (submodule foo)`
(i.e., one that already has `name` defined).

This adds a new type `args` that will just merge the topmost definition.
@furrycatherder
Copy link
Contributor Author

furrycatherder commented Jan 5, 2019 •
edited

I'm not sure if this is the best way to handle it, so please let me know. I ran into this issue here: https://github.com/furrycatherder/bento-xdg-config/blob/b11132fb96c74f3fb04473b64c8718890b1b6cf9/bento/default.nix#L55

@furrycatherder furrycatherder mentioned this pull request Jan 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@furrycatherder