Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests: add osrm-backend test #53442

Merged
merged 1 commit into from Feb 8, 2019
Merged

Conversation

erictapen
Copy link
Member

Motivation for this change

Better testing for the osrm module.

Things done

Added a test, that loads a real world file of Monaco and then runs a query against it.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

@GrahamcOfBorg build nixosTests.osrm-backend

@erictapen
Copy link
Member Author

@GrahamcOfBorg build nixosTests.osrm-backend

@ryantm
Copy link
Member

ryantm commented Feb 6, 2019

@GrahamcOfBorg test osrm-backend

@ryantm
Copy link
Member

ryantm commented Feb 7, 2019

@grahamc Did I do something wrong to trigger this test to run?

@grahamc
Copy link
Member

grahamc commented Feb 8, 2019

@GrahamcOfBorg test osrm-backend

@ryantm ryantm merged commit d2904c8 into NixOS:master Feb 8, 2019
@ryantm
Copy link
Member

ryantm commented Feb 8, 2019

@erictapen thanks!

@erictapen
Copy link
Member Author

Yay, first merged NixOS test! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants