mysql: add restartTrigger for my.cnf #54475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makefu
reviewed
Jan 29, 2019
| @@ -249,6 +249,7 @@ in | |||
|
|
|||
| after = [ "network.target" ]; | |||
| wantedBy = [ "multi-user.target" ]; | |||
| restartTriggers = [ config.environment.etc."my.cnf".source ]; | |||
There was a problem hiding this comment.
Is the variable working as you would expect? config.environment.etc."my.cnf".source points into /nix/store to a static file. It may work when you set restartIfChanged for te service.
I'd guess that /etc/my.cnf is the correct thing to put here, however i have not yet debugged restartTriggers.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah okay, restartTriggers (and therefore X-Restart-Triggers) is actually NixOS specific and a random commit in nixpkgs actually contains the documentation:
The triggers are just arbitrary strings that are included in the unit
under X-Restart-Triggers. The idea is that if they change between
reconfigurations, switch-to-configuration will restart the unit
because its store path changed. This is mostly useful for services
that implicitly depend on generated files in /etc. Thus you can say
restartTriggers = [ confFile ];
where ‘confFile’ is the derivation that generated the /etc file in
question.
makefu
approved these changes
Jan 29, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow restart mysql.service on change config my.cnf
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)