New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: Check for a valid umask before running multi-user installer. #2643
Conversation
Instead of checking for a correct umask, isn't it better to just set the correct umask (e.g. |
There are potential consequences, side-affects, when setting your umask which was why I failed with an error. I would be more inclined to just set the correct directory permissions on |
I made changes to I attempted to extend the README to include my use case:
Here was the additional test case I added. I wasn't sure if I should check the umask change on every distro or. I thought I would be able to use
|
Fixes #2377 and #1560. I tested this on Linux (Ubuntu 16.04). I'm not sure if the arguments for
sed
on darwin are different, and I don't have a mac/bsd machine to test on.