gst-plugins-good: Add missing xfixes/xdamage dependencies #54463
Conversation
| @@ -6,6 +6,7 @@ | |||
| , libsoup, libpulseaudio, libintl | |||
| , darwin, lame, mpg123, twolame | |||
| , gtkSupport ? false, gtk3 ? null | |||
| , xorg | |||
There was a problem hiding this comment.
as far as I remember, xorg entries are also searched automatically by callPackage, so you can ask for libXfixes and libXdamage directly.
There was a problem hiding this comment.
Is that better though? I find it very implicit / non-obvious that this works, given that libXfixes is not in a top-level all-packages entry.
There was a problem hiding this comment.
Well, callPackage is supposed to use top-level and xorg definitions. Maybe a few refactorings back, when callPackage was defined inside all-packages.nix and not splice.nix, it was a bit more evident…
There was a problem hiding this comment.
Where is it described how that works and what it will pass?
Unless it's described somewhere so it's obvious to readers where it comes from, I'd like to use the current approach which leaves no doubt.
There was a problem hiding this comment.
callPackage, and especially what it actually does — let alone how, is basically not described well anywhere (I could say
Line 87 in 1578559
xorg, but it is not exactly easy to find without having an idea in advance)
There was a problem hiding this comment.
I take this as an argument for using the explicit approach I have for now -- unless I misunderstood.
There was a problem hiding this comment.
No, basically all of non-server Nixpkgs break if top-level callPackage stops passing stuff from xorg, so the expectation is to rely on this behviour.
There was a problem hiding this comment.
OK, I've switched to using them directly instead via xorg.
|
I've updated the PR to also depend on |
|
I've addressed the SRT-related comments in #54380, and rebased this. #54380 is ready to merge from my side. After it's merged, this one is ready too from my side. I'm impartial on the topic of #54463 (comment), whichever you guys think is cleaner. |
That merge is done now; ready from my side. |
Fixes mouse curser not being visible (show-pointer=true and use-damage=true having no effect) in `ximagesrc`.
|
Since the refactoring/renaming didn't change the derivation, merging. |
Based on #54380, merge that first (done).
Motivation for this change
Fixes mouse curser not being visible (show-pointer=true and use-damage=true having no effect) in
ximagesrc.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)