Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efitools: init at 1.9.2 #54471

Merged
merged 1 commit into from Jan 22, 2019
Merged

efitools: init at 1.9.2 #54471

merged 1 commit into from Jan 22, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 22, 2019

Motivation for this change

Packaged as part of #53901

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member Author

grahamc commented Jan 22, 2019

Fixed up!

symphorien
symphorien reviewed Jan 22, 2019
View reviewed changes
pkgs/tools/security/efitools/default.nix
sbsigntool
perl
perlPackages.FileSlurp
help2man
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help2man and probably perl should be nativeBuildInputs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up!

@grahamc grahamc mentioned this pull request Jan 22, 2019
Closed
@grahamc grahamc merged commit f3e2348 into NixOS:master Jan 22, 2019
@grahamc grahamc deleted the efitools branch January 22, 2019 15:42
@symphorien symphorien mentioned this pull request Jan 23, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

@symphorien symphorien symphorien left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grahamc @samueldr @symphorien @GrahamcOfBorg