Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datadog-agent: 6.8.3 -> 6.9.0 #54478

Merged
merged 1 commit into from Jan 27, 2019
Merged

datadog-agent: 6.8.3 -> 6.9.0 #54478

merged 1 commit into from Jan 27, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jan 22, 2019 •
edited

Motivation for this change

Update version to 6.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jan 22, 2019 •
edited by ghost

LGTM 👍

rvl
rvl approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked output of agent version, checked serialization dep in Gopkg.toml is still 4.7.1. Thanks.

@domenkozar domenkozar merged commit 8441a62 into NixOS:master Jan 27, 2019
@Izorkin Izorkin deleted the datadog-agent branch January 27, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @rvl @domenkozar @GrahamcOfBorg