Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: 20181201_a -> 20190101_b #54465

Merged
merged 1 commit into from Jan 29, 2019
Merged

gildas: 20181201_a -> 20190101_b #54465

merged 1 commit into from Jan 29, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Jan 22, 2019 •
edited

Motivation for this change

Update Gildas to the latest upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
Copy link
Member Author

smaret commented Jan 22, 2019

The build on Darwin is blocked by #54424.

@smaret
Copy link
Member Author

smaret commented Jan 28, 2019 •
edited

#54424 has been fixed in master. I've rebased this branch on top of it and the new Gildas version now builds on Darwin.

@globin globin merged commit d5f4b2b into NixOS:master Jan 29, 2019
@smaret smaret deleted the gildas-update branch January 29, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smaret @globin @GrahamcOfBorg