redshift: Install systemd user unit files #54480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Jan 22, 2019
jabranham
force-pushed
the
redshift-systemd
branch
from
c2aa0ab
to
4297e58
Compare
| @@ -44,7 +45,7 @@ stdenv.mkDerivation rec { | |||
| "--enable-drm=${if withDrm then "yes" else "no"}" | |||
| "--enable-quartz=${if withQuartz then "yes" else "no"}" | |||
| "--enable-corelocation=${if withCoreLocation then "yes" else "no"}" | |||
| ]; | |||
| ] ++ stdenv.lib.optional (stdenv.isLinux && useSystemd) "--with-systemduserunitdir=\${out}/lib/systemd/user"; | |||
There was a problem hiding this comment.
Suggested change
| ] ++ stdenv.lib.optional (stdenv.isLinux && useSystemd) "--with-systemduserunitdir=\${out}/lib/systemd/user"; | |
| ] ++ stdenv.lib.optional (stdenv.isLinux && useSystemd) "--with-systemduserunitdir=${placeholder "out"}/lib/systemd/user"; |
|
Just checked and we can't use these service files since we pass extra flags to the But I guess for other Linux distributions we should still have them installed. |
|
Oh, I didn't know about the redshift options on NixOS. I usually use these at the user level because I have two accounts, one of which uses redshift and the other doesn't. There's currently no way to specify that in NixOS, though, as far as I can tell. |
|
We can just override the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
redshift's systemd user units currently aren't installed. This installs them.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)