Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picocom: Enable on Darwin #54479

Merged
merged 1 commit into from Jan 22, 2019
Merged

picocom: Enable on Darwin #54479

merged 1 commit into from Jan 22, 2019

Conversation

gefla
Copy link

@gefla gefla commented Jan 22, 2019

Motivation for this change

The source package already supports Darwin. This change allows using the package with Nix on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

picocom: Enable on Darwin
1066a1a 
Sets package platform to Unix and adds IOKit dependency on Darwin.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jan 22, 2019
@veprbl
Copy link
Member

veprbl commented Jan 22, 2019

@GrahamcOfBorg build picocom

@veprbl veprbl merged commit 7be4f45 into NixOS:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gefla @veprbl @GrahamcOfBorg @Janik-Haag