Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: add python to the runtime closure #54472

Merged
merged 2 commits into from Jan 22, 2019
Merged

bazel: add python to the runtime closure #54472

merged 2 commits into from Jan 22, 2019

Conversation

Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Jan 22, 2019 •
edited

Motivation for this change

See commit
cc @NinjaTrappeur

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build bazel.pythonBinPath

@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build bazel.tests.pythonBinPath

@Profpatsch Profpatsch force-pushed the bazel-add-python-to-runtime-closure branch from 547297d to 9a32670 Compare January 22, 2019 18:56
@Profpatsch
Copy link
Member Author

@GrahamcOfBorg build bazel.tests.pythonBinPath

@Profpatsch Profpatsch merged commit 88fa235 into NixOS:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Profpatsch @GrahamcOfBorg