Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.grv: use buildGoPackage instead of buildGo19Package #54908

Merged
merged 1 commit into from Jan 30, 2019
Merged

gitAndTools.grv: use buildGoPackage instead of buildGo19Package #54908

merged 1 commit into from Jan 30, 2019

Conversation

andir
Copy link
Member

@andir andir commented Jan 30, 2019

Motivation for this change

Fixing build of Grv after Go1.9 has been marked as insecure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jan 30, 2019

@GrahamcOfBorg build gitAndTools.grv

@andir
Copy link
Member Author

andir commented Jan 30, 2019

The build succeeds on Darwin again. The updated Go version seems to have removed the previously observed issue (6b7cefd).

@dtzWill
Copy link
Member

dtzWill commented Jan 30, 2019

Oh, hooray!

@dtzWill
Copy link
Member

dtzWill commented Jan 30, 2019

I remember thinking this was the last in-tree go 1.9 user, grep suggests this might indeed be the case!

So maybe we can drop it soon (as insecure, unsupported)?

@dtzWill dtzWill merged commit f2a1a4e into NixOS:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @dtzWill