Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.just-start: init at 2018-10-25 #54907

Closed
wants to merge 2 commits into from
Closed

python3Packages.just-start: init at 2018-10-25 #54907

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner January 30, 2019 00:12
dotlambda
dotlambda reviewed Jan 30, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/samuelcolvin/pydantic/blob/v0.18.2/setup.py#L52, a disabled = !isPy3k is missing.

pkgs/development/python-modules/just-start/default.nix Outdated

LC_ALL = "C.UTF-8";

# Fails with message complaining about our fake $HOME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set

preCheck = ''
  export HOME=$(mktemp -d)
'';

pkgs/development/python-modules/just-start/default.nix Outdated
doCheck = false;

meta = with lib; {
description = "An app to defeat procrastination (terminal pomodoro w/taskwarrior)";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's an application, why put it in pythonPackages?

@dtzWill
python3Packages.pydantic: init at 0.23
abbac54
@dtzWill
python3Packages.just-start: init at 2019-03-30
0a3adf7 
* updated for review feedback, thanks!
* update to latest, since been while since submitted :)
* now using poetry/pyproject (TIL about those)
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

Nothing happening so closing.

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @FRidh @dotlambda @ryantm @GrahamcOfBorg