androidenv: move licenseAccepted condition to androidsdk #54915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NDK can be built without accepting the license.
Mic92
approved these changes
Jan 30, 2019
|
It's fine with me to change the policy, but I'm not sure about the legal
implications. Most of the Android SDK plugins are also subject to a
proprietrary EULA, although the EULA also states that if an open source
license applies that will take precedence. The reason why this check is for
everything Android SDK related, is because most plugins now have a
complicated EULA.
…On Wed, Jan 30, 2019 at 8:53 AM Jörg Thalheim ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#54915 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGY90x_WIdXrLrPLkiBT62eqZnzE215ks5vIU9sgaJpZM4aZUI8>
.
|
|
Yeah it gets kind of awkward with determining each of these right now. I think the situation can improve over time though. The end goal will be to make a fully built Android toolchain. We are already like 90% of the way there. The big thing left is building BIONIC from source. But until then I want to make sure we keep most of Nixpkgs at least partly Android-compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Android stuff was not being built on hydra. The NDK can be used without accepting the SDK license. This moves that condition to androidsdk.