Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compton-git: 2 -> 5 #54914

Merged
merged 2 commits into from Jan 30, 2019
Merged

compton-git: 2 -> 5 #54914

merged 2 commits into from Jan 30, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 30, 2019

https://github.com/yshui/compton/releases/tag/v3
https://github.com/yshui/compton/releases/tag/v4
https://github.com/yshui/compton/releases/tag/v5

Some fixes were made shortly after v5,
should pick them up or wait for next release.
(as-is it's somewhat broken unfortunately)

Even so, submitting to hopefuly avoid sitting
on these updates even longer :).

Motivation for this change

home-manager users may be interested in
dtzWill/home-manager@c4c2ed4
(otherwise the generated config is rejected by compton)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 30, 2019

@GrahamcOfBorg build compton-git

@Mic92 Mic92 merged commit b35cee1 into NixOS:master Jan 30, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 30, 2019

Did I merge this too fast?

@dtzWill
Copy link
Member Author

dtzWill commented Jan 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants