Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epson-escpr2: init at 1.0.29 #54906

Merged
merged 1 commit into from Apr 12, 2019
Merged

Conversation

furrycatherder
Copy link
Contributor

@furrycatherder furrycatherder commented Jan 30, 2019

Motivation for this change

Printer drivers for e.g. EPSON WF-2860 were missing and require epson-escpr2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build epson-escpr2

@joachifm
Copy link
Contributor

Looks like src url is no longer valid:

curl: (22) The requested URL returned error: 404 Not Found

@furrycatherder
Copy link
Contributor Author

furrycatherder commented Apr 12, 2019

Epson keeps deleting old drivers. Can we get it accepted and cached in Hydra in time? Is there an alternative approach you might suggest?

@joachifm
Copy link
Contributor

Hm, I suppose asking upstream to provide stable urls would be pointless. Other than that, I suppose relying on tarballs.nixos.org or some other mirror (debian?) is as good as it gets.

@joachifm joachifm merged commit 3ceb958 into NixOS:master Apr 12, 2019
@furrycatherder
Copy link
Contributor Author

I will update the source URL with the latest and open another PR.

@d-goldin d-goldin mentioned this pull request Sep 24, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants