pyspark: 2.3.2 -> 2.4.0, fix version bounds #54898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Jan 29, 2019
| }; | ||
|
|
||
| # pypandoc is broken with pandoc2, so we just lose docs. | ||
| postPatch = '' | ||
| sed -i "s/'pypandoc'//" setup.py | ||
|
|
||
| # Current release works fine with py4j 0.10.8.1 | ||
| substituteInPlace setup.py --replace py4j==0.10.7 py4j==0.10.8.1 |
There was a problem hiding this comment.
Wouldn't it make sense to specify something like py4j>=0.10.7,<0.11?
py4j seems to work fine with this version
matthewbauer
force-pushed
the
pyspark-fix
branch
from
98acf77
to
c0f8270
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
6.topic: python
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py4j seems to work fine with this version