Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] prometheus-node-exporter: remove go 1.9 pinning #54910

Merged
merged 1 commit into from Jan 30, 2019
Merged

[18.09] prometheus-node-exporter: remove go 1.9 pinning #54910

merged 1 commit into from Jan 30, 2019

Conversation

andir
Copy link
Member

@andir andir commented Jan 30, 2019

Motivation for this change

Since Go1.9 has been marked as insecure (5a3e195) all setups relying on the prometheus-node-exporter would fail to build a new generation.

With Go1.11 the daemon seems to work just fine. I was unable to observe
any crashes (due to the wifi module being loaded).

cc @WilliButz, can you verify that it also runs for you?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • The varnish exporter test failed but the others succeded. It did not look like this change could have potentially introduced the varnish error so I ignored it.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
prometheus-node-exporter: remove go 1.9 pinning
4f6152a 
With Go1.11 the daemon seems to work just fine. I was unable to observe
any crashes (due to the wifi module being loaded).
@Mic92
Copy link
Member

Mic92 commented Jan 30, 2019

@GrahamcOfBorg build prometheus-node-exporter

@Mic92
Copy link
Member

Mic92 commented Jan 30, 2019

@GrahamcOfBorg test prometheus-exporters

WilliButz
WilliButz approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me, thank you for removing the version pinning 👍

@andir andir merged commit bc739d0 into NixOS:release-18.09 Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @Mic92 @WilliButz @GrahamcOfBorg