Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #54900 #54901

Merged
merged 1 commit into from Feb 14, 2019
Merged

Backport #54900 #54901

merged 1 commit into from Feb 14, 2019

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Backport #54900 for nixos-18.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil merged commit 31d5572 into NixOS:release-18.09 Feb 14, 2019
@grahamc
Copy link
Member

grahamc commented Feb 15, 2019

Seems this broken 18.09, reverted in a1156b9:

error: while evaluating anonymous function at /build/source/maintainers/scripts/find-tarballs.nix:6:1, called from undefined position:
while evaluating 'operator' at /build/source/maintainers/scripts/find-tarballs.nix:27:16, called from undefined position:
while evaluating 'immediateDependenciesOf' at /build/source/maintainers/scripts/find-tarballs.nix:39:29, called from /build/source/maintainers/scripts/find-tarballs.nix:27:44:
while evaluating anonymous function at /build/source/lib/attrsets.nix:225:10, called from undefined position:
while evaluating anonymous function at /build/source/maintainers/scripts/find-tarballs.nix:40:37, called from /build/source/lib/attrsets.nix:225:16:
while evaluating 'derivationsIn' at /build/source/maintainers/scripts/find-tarballs.nix:42:19, called from /build/source/maintainers/scripts/find-tarballs.nix:40:40:
while evaluating 'optional' at /build/source/lib/lists.nix:241:20, called from /build/source/maintainers/scripts/find-tarballs.nix:44:33:
while evaluating 'canEval' at /build/source/maintainers/scripts/find-tarballs.nix:48:13, called from /build/source/maintainers/scripts/find-tarballs.nix:44:43:
while evaluating the attribute 'drvPath' at /build/source/lib/customisation.nix:149:7:
while evaluating the derivation attribute 'name' at /build/source/pkgs/stdenv/generic/make-derivation.nix:177:11:
while evaluating 'nullSrc' at /build/source/pkgs/development/haskell-modules/make-package-set.nix:263:19, called from undefined position:
while evaluating 'overrideCabal' at /build/source/pkgs/development/haskell-modules/lib.nix:37:24, called from /build/source/pkgs/development/haskell-modules/make-package-set.nix:263:22:
attribute 'override' missing, at /build/source/pkgs/development/haskell-modules/lib.nix:37:28

@grahamc
Copy link
Member

grahamc commented Feb 15, 2019

re https://hydra.nixos.org/build/88813205/nixlog/1

@vcunat
Copy link
Member

vcunat commented Feb 15, 2019

The same happens now on master as well: https://hydra.nixos.org/build/88833116

@infinisil infinisil mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ElvishJerricco @grahamc @vcunat @infinisil @GrahamcOfBorg