nixos/modules: add greenclip user service #54913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya, this looks cool ! |
|
arf sry I tried to resolve the conflict via github's ui but seems like it merged current master into the branch. Better drop my commit and properly rebase. |
|
@teto Just rebased 😃 |
teto
reviewed
Jul 22, 2019
| in { | ||
|
|
||
| options.services.greenclip = { | ||
| enable = mkEnableOption "Whether to enable the greenclip daemon that will listen to selections"; |
There was a problem hiding this comment.
mkEnableOption is defined as ```
mkEnableOption =
# Name for the created option
name: mkOption {
default = false;
example = true;
description = "Whether to enable ${name}.";
type = lib.types.bool;
};
so the current value is not good. "Greenclip daemon" should be enough ?
There was a problem hiding this comment.
@teto True, just saw the mkEnableOption source. Fixed.
|
the systemd service looks fine to me but I am no expert. I guess it can be refined later in case of problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
greenclip is a tool for managing your clipboard with rofi. see https://github.com/erebe/greenclip
The greenclip package(
haskellPackages.greenclip) is already available, this is just for adding a nixos systemd user service forgreenclip daemon.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)