Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion when building long road at map border #7142

Closed
PeterN opened this issue Jan 30, 2019 · 1 comment
Closed

Assertion when building long road at map border #7142

PeterN opened this issue Jan 30, 2019 · 1 comment

Comments

@PeterN
Copy link
Member

PeterN commented Jan 30, 2019 •
edited

Version of OpenTTD

OpenTTD 20190129-master-g6a56a4ceM

Expected result

Building a road over multiple tiles starting at tile 0. The action should error because all the tiles are water.

Actual result

Game crashes due to out of bounds map array test.

src/tile_map.h: 100 : TileType GetTileType(TileIndex): Assertion `tile < MapSize()' failed.

Steps to reproduce

  • Edit openttd.cfg and set freeform_edges to false. This removes the MP_VOID tiles from the top map edges.
  • Create a new map, any settings.
  • Select road tool, and drag from tile 0 down the map.
  • Game will crash.

This only happens if freeform_edges is false, such as in the regression test savegame.
@PeterN
Copy link
Member Author

PeterN commented Jan 30, 2019

This was noticed in regression testing #6811, however the assertion also happens in plain master.

PeterN added a commit to PeterN/OpenTTD that referenced this issue Jan 30, 2019
@PeterN
Fix OpenTTD#7142: Missing map bounds check when building long roads.
16a2a5b
@PeterN PeterN mentioned this issue Jan 30, 2019
Merged
PeterN added a commit to PeterN/OpenTTD that referenced this issue Jan 30, 2019
@PeterN
Fix OpenTTD#7142: Missing map bounds check when building long roads.
60ef98a
@PeterN PeterN closed this as completed in e982b91 Jan 30, 2019
@PeterN PeterN mentioned this issue Jan 30, 2019
Merged
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@PeterN @nielsmh
Fix OpenTTD#7142: Missing map bounds check when building long roads.
d5189a1
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@PeterN @douiwby
Fix OpenTTD#7142: Missing map bounds check when building long roads.
be48825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PeterN